Fixed to work with RN 0.58+

[Eugnis]

Starting from RN 0.58 commit DeltaPatcher: better support for the new Delta format react-native-debugger stopped working with error, look issue #292
This PR fixes #292, checked on Windows.

[RWOverdijk]

Gave it a run, and first glance it works for me.

[wvmitchell]

Confirmed works for me on OSX 10.14.2. Nice catch @Eugnis!

RN 0.58.3
Xcode 10.1

[jhen0409]

Thanks, I'll release it as soon as possible, and sorry for delay.

[mrTuomoK]

So this this should now work? I'm creating a new project --> react-native init xxx and then running in the iOS simulator... then debugging remotely gives me this error which was thought to be fixed?

"react": "16.6.3",
"react-native": "0.58.3"

Xcode Version 10.1 (10B61)

Any ideas? Or is the fix still on it's way?

UPDATE --> I installed React Native Debugger and everything works now... So is it Chrome to blame?

2nd update --> still when debugging I sometimes get "Unable to find module for DevLoadingView" in the simulator when debugging... disappears after refresh

[hatemalimam]

Thanks for the update, as @mrTuomoK has mentioned, sometimes we are getting Unable to find module for DevLoadingView after a refresh it disappears, any idea about that ?

[Eugnis]

Can you open new issue with this error and screenshot or stack trace if present? I'm unable to reproduce this exception on my setup.
On first sight this PR not related to this error but there might be another changes in RN 0.58 so error appeared.

[rmilejcz]

I'm still getting this error on 0.58.3

Uncaught (in promise) TypeError: Iterator value v is not an entry object
    at new Map (<anonymous>)
    at deltaUrlToBlobUrl

Dependencies:

"react-native": "0.58.3"
"react":"16.7.0"

Error is here:

    const deltaPatcher = client.applyDelta({
      id: bundle.id,
      pre: new Map(bundle.pre), // <-- fails here
      post: new Map(bundle.post),
      delta: new Map(bundle.delta),
      reset: bundle.reset,
    });

I assume I'm doing something incorrect so I'm posting here, but if not I will open an issue on the rn repo. Caveat is that I'm also using TypeScript, my rn-cli.config.js:

var config = {
  getTransformModulePath() {
    return require.resolve('react-native-typescript-transformer');
  },
  getSourceExts() {
    return ['ts', 'tsx'];
  },
};
module.exports = config;

And I am running the package manager manually

cd $PROJECT_ROOT && react-native start --config $PROJECT_ROOT/rn-cli.config.js --reset-cache

[mrTuomoK]

More info again on this.... Tried to change my simulator device and at least iPhone 7 Plus works perfectly.... but when using for example iPhone XR the problem comes up again

[Eugnis]

@rmilejcz

Error is here:

    const deltaPatcher = client.applyDelta({
      id: bundle.id,
      pre: new Map(bundle.pre), // <-- fails here
      post: new Map(bundle.post),
      delta: new Map(bundle.delta),
      reset: bundle.reset,
    });

Hello, seems you're using old version of react-native-debugger before fix. In current release this code is changed

react-native-debugger/app/middlewares/delta/deltaUrlToBlobUrl.js

Lines 31 to 37 in 0ecd298

	const deltaPatcher = client.applyDelta(isOld ? {
	id: bundle.id,
	pre: new Map(bundle.pre),
	post: new Map(bundle.post),
	delta: new Map(bundle.delta),
	reset: bundle.reset,
	} : bundle);

[rmilejcz]

I'm a bit confused then, do I need to update react-native-debugger myself? I've deleted and reinstalled node-modules but I still seem to have the old version. For now I guess I will just make this change myself, thanks for the clarification!

[Eugnis]

@rmilejcz That's not only that file changed, here's all changes of this PR
Btw, you can better download react-native-debugger from releases which is already several versions above

[rmilejcz]

@Eugnis oh okay that's embarrassing, I was using chrome to debug instead of the standalone. With the standalone debugger everything works great. Thanks for your help!