Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN 0.59: Avoid AsyncStorage warning by re-wrap the native module #324

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

jhen0409
Copy link
Owner

@jhen0409 jhen0409 commented Feb 16, 2019

Since we used AsyncStorage to made context menu functions of RNDebugger, it caused the warning in RN ^0.59:

ExceptionsManager.js:82 Warning: Async Storage has been extracted from react-native core and will be removed in a future release. It can now be installed and imported from '@react-native-community/async-storage' instead of 'react-native'. See https://github.com/react-native-community/react-native-async-storage

Just use NativeModules to re-wrap the module to avoid the warning. It also fixes the issue of AsyncStorage functions of context menu in future RN versions.

@jhen0409 jhen0409 merged commit ca55c69 into master Feb 16, 2019
@jhen0409 jhen0409 deleted the rn59-async-storage-warn branch February 16, 2019 00:21
cryptodev523 pushed a commit to cryptodev523/react-native-debugger that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant