Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix figures and update overleaf #31

Merged
merged 13 commits into from
Jun 16, 2023
Merged

Fix figures and update overleaf #31

merged 13 commits into from
Jun 16, 2023

Conversation

EzryStIago
Copy link
Collaborator

Reviewer C noted that our sample data from step D was poorly converged. We replaced the sample data a while ago, but failed to update the sample figures. They have been regenerated in this branch.

@EzryStIago EzryStIago requested a review from jhenin May 25, 2023 21:29
Copy link
Owner

@jhenin jhenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figures look good. Some file names have changed - this should be accompanied by changes in references to those files in latex sources.

@jhenin
Copy link
Owner

jhenin commented May 26, 2023

correction: some of these need to be propagated to the text_src/Figures/ directory, and "bound_generalFigures" should be renamed in the latex source.

@EzryStIago
Copy link
Collaborator Author

@jhenin I've updated all with the latest version from Overleaf which already has the updated figures.

@EzryStIago EzryStIago changed the title Fix figures Fix figures and update overleaf May 30, 2023
typo: "appendix appendix"

bug: refs to appendix A were linking to the introduction. Fixed by adding flag to href setup.
@EzryStIago EzryStIago mentioned this pull request May 30, 2023
This reverts commit 32bd6a846e402cb25b9f243d29b03aadf31644ee.
This reverts commit 1efb27c70b0c3fea89faf062215065ecd42135ff.
@jhenin
Copy link
Owner

jhenin commented Jun 2, 2023

In the new output, the number "ΔGsite = 14.5±0.0 kcal/mol" looks suspicious.

@jhenin jhenin merged commit bef7630 into main Jun 16, 2023
@EzryStIago EzryStIago deleted the fixStepDFigures branch June 29, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants