Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable names #41

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Fix variable names #41

merged 4 commits into from
Nov 10, 2023

Conversation

EzryStIago
Copy link
Collaborator

Each variable should now be unique. This should prevent issues with moving around the notebook non-linearly.
re: Issue #40

Key changes:
Variable renames
Comment clarifications
Swapped the order of the user parameter cells so paths are all together

@EzryStIago EzryStIago added the bug Something isn't working label Nov 10, 2023
@jhenin jhenin self-requested a review November 10, 2023 07:34
Copy link
Owner

@jhenin jhenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! For consistency with the text notations, I would change the _bound suffix to _site.
I like the idea of making the plot parameters more explicit, too.

@jhenin jhenin self-requested a review November 10, 2023 07:50
@jhenin jhenin merged commit 4017a16 into main Nov 10, 2023
@jhenin jhenin mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants