feat: skip empty parameters (#313)

jhillyerd · Dec 12, 2023 · 54fdf4d · 54fdf4d
1 parent ea70bfe
commit 54fdf4d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/mediatype/mediatype.go b/mediatype/mediatype.go
@@ -122,6 +122,12 @@ func fixMangledMediaType(mtype string, sep rune) string {
 			p = coding.RFC2047Decode(p)
 
 			pair := strings.SplitAfter(p, "=")
+
+			if strings.TrimSpace(pair[0]) == "=" {
+				// Ignore unnamed parameters.
+				continue
+			}
+
 			if strings.Contains(mtype, strings.TrimSpace(pair[0])) {
 				// Ignore repeated parameters.
 				continue

diff --git a/mediatype/mediatype_test.go b/mediatype/mediatype_test.go
@@ -46,6 +46,12 @@ func TestFixMangledMediaType(t *testing.T) {
 			sep:   ';',
 			want:  `image/png; name="abc.png"`,
 		},
+		{
+			// Removes empty parameters in the middle
+			input: `Content-Type: text/html; =""; charset=""`,
+			sep:   ';',
+			want:  `Content-Type: text/html; charset=""`,
+		},
 		{
 			input: "application/octet-stream;=?UTF-8?B?bmFtZT0iw7DCn8KUwoo=?=You've got a new voice miss call.msg",
 			sep:   ';',