Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip empty parameters #313

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

milankonir
Copy link
Contributor

@milankonir milankonir commented Dec 12, 2023

Looks like there was never a proper condition for filtering out empty parameters. It kinda worked thanks to this https://github.com/jhillyerd/enmime/blob/main/mediatype/mediatype.go#L125-L128 (= substring would always match if there was at least one parameter already added to mtype). It did not work if the empty parameter was the first parameter.

@coveralls
Copy link

coveralls commented Dec 12, 2023

Coverage Status

coverage: 86.213% (+0.01%) from 86.199%
when pulling 7c1c20c on milankonir:fix-mangled-unnamed-parameter
into ea70bfe on jhillyerd:main.

@jhillyerd jhillyerd merged commit 54fdf4d into jhillyerd:main Dec 12, 2023
9 checks passed
@jhillyerd
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants