fix: parse address joined by semicolons #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokasianenko-outreach
changed the title
jhillyerd
requested changes
Mar 16, 2022
There was a problem hiding this comment.
One minor comment nitpick.
Can we also add a semicolon separated list or two to https://github.com/jhillyerd/enmime/blob/master/envelope_test.go#L761 ?
dmytrokasianenko-outreach
force-pushed
the
dmytrokasianenko-outreach/fix/semicolon-address
branch
from
5596dfc
to
a69cca3
Compare
Added 🙂 |
dmytrokasianenko-outreach
deleted the
dmytrokasianenko-outreach/fix/semicolon-address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for semicolons in address. Should handle addresses joined by semicolon and remove semicolons where necessary