Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unique IDs to Envelope's Parts #35

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

philipyaz
Copy link

@philipyaz philipyaz commented Nov 2, 2017

cf. issue "Add Unique ID's to Envelope's Parts" #36

In my proposition, the Parts' PartIDs will look as such:

multipart/alternative                                       PartID = 0 (root)
|-- text/plain                                                    PartID = 1
|-- multipart/related                                        PartID = 2.0 ("multipart/")
|     |-- text/html                                               PartID = 2.1
|     |-- image/png, disposition: inline, filename: "img3.png"   PartID = 2.2
|     |-- multipart/related                                  PartID = 2.3.0 ("multipart/")
|     | `-- text/html                                            PartID = 2.3.1
|     `-- image/png, disposition: inline, filename: "img3.png"   PartID = 2.4
`-- image/png, disposition: inline, filename: "img3.png"         PartID = 3

@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage increased (+0.3%) to 86.253% when pulling 366219f on philipyaz:feature/PartID into a22a93f on jhillyerd:develop.

@philipyaz philipyaz changed the title Add Unique ID's to Envelope's Parts Add Unique IDs to Envelope's Parts Nov 2, 2017
@jhillyerd jhillyerd merged commit 1af62a1 into jhillyerd:develop Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants