Feature/epilogue parsing #41
Conversation
…into develop * 'feature/PartID' of https://github.com/philipyaz/enmime: Add Unique ID's to Envelope's Parts
…enmime into develop * 'feature/RestoreBuffer' of https://github.com/philipyaz/enmime: Restore the Part's buffer after reading its content
…nmime into develop * 'feature/RootBoundary' of https://github.com/philipyaz/enmime: Set the Part boundary field for the Envelope's root
|
Hi Pedro, some thoughts: It's not a good idea to merge other PRs into your own, it makes it much harder for me to see what your proposed change is - and if I end up rejecting or requesting changes to the other PRs, it leaves your PR in an unknown state. Including chunks of MIME test data in the test.go files isn't idiomatic for this project. If you can make it work with testdata files, that would be ideal - or let me know why this test breaks the precedence. I would also not recommend changing the whitespace of a file you edit - or make sure to revert it back, as it adds noise to that PR. I am not a git expert, but at this point I'd recommend creating a new branch based off of enmime develop, and cherry picking just your changes into it. You could also try a rebase of your existing branch, but I'm not sure if that would blow up given the other PRs rolled into it. |
|
Closing this, work continues in #48 |
This PR works on top of the work done by @philipyaz on PR #39, #37 and #35 in order to solve the issue described in #32