Restore the Part's buffer after reading its content #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
jhillyerd
added a commit
that referenced
this pull request
Jan 8, 2018
Part content readers make everything more complicated for no benefit. See #37, #38, #45. They also prevent some errors from being surfaced in the Part object, as they haven't been detected at the time it is returned to the client. Part.Content []byte is now the recommended way to access the content of a Part. Part.Content will also be used when generating MIME emails, for #7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. issue "Restore the Part's buffer after reading its content" #38