-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install and test generator-jhipster-entity-audit #2
Comments
Ok these are new errors which im not seeing when i run the same steps in my
|
We can have same OS => devbox Have a look this morning at your code. What I see is, when launching for example :
I think there is something to play with |
yes i think so something to do with run loops more than the async i guess im gonna try something on that line |
I have corrected all the errors you mentioned above but the issue still persists I have opened a ticket in yeoman project as well yeoman/yeoman#1582 |
@pascalgrimaud @cbornet @gmarziou @jdubois I have debugged this for a while and I think here is what happens. Yeoman puts all the methods in a run queue, the methods are sorted on priority and priority is by method name, so they have this names like install, writing, promting etc which will be run in certain priority and any methods with this name will be run in that particular order, methods can be lumbed together inside a priorityName to ensure order, every other method will be running in default order. Our entity generator doesn't follow this naming and all methods are run in default order which i doubt is after writing method and hence, the modules writing is done before the entity generator file method. Im gonna try to refactor the entity gen index.js to adher to the naming convention to see if the issue gets resolved. |
My bad... 😩 I didn't notice our entity generator doesn't follow this naming. |
yes and if im not wrong default methods are run between prompting -> writing but not very sure, it looks like so from debug logs |
I have rewrote entity gen to follow this order will put in a PR later |
sorry this is correct order initializing - Your initialization methods (checking current project state, getting configs, etc) |
And voila that was the issue its working now 😂 |
This is the order in which entity generator runs now
|
nice 👍 |
👏 |
ill commit these soon 👍 |
Yes, great job! On Tue, Jan 5, 2016 at 9:32 AM, Deepu k Sasidharan <notifications@github.com
Julien Dubois Twitter: @julienDubois http://twitter.com/#!/juliendubois |
version 1.0 released, but need to wait for next JHipster release :( |
closed via jhipster/generator-jhipster#2569 |
I open an issue here, it will be easier than by mail because we got markdown!
I hope it's ok for you, @deepu105
So I made some tests with our devbox. Here all my commands. Hope it will help you...
Step1 : clone your fork deepu105/generator-jhipster, branch module-hook
Step2 : clone your module deepu105/generator-jhipster-entity-audit
Step3 : create a sample project
I answered to all questions, all by default
Step4 : launch your sub module
.jhipster
directory --> maybe it's intentionalStep5 : create simple entity
Step6 : launch sub module
And the
.jhipster-modules.json
file is empty too.Step 7 : I modify manually the .jhipster-modules.json
Step 8 : I create a new entity, it should be hook by your sub module
The text was updated successfully, but these errors were encountered: