Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Angular 14 and Capacitor 4 #712

Merged
merged 23 commits into from
Sep 4, 2022
Merged

Add support for Angular 14 and Capacitor 4 #712

merged 23 commits into from
Sep 4, 2022

Conversation

mraible
Copy link
Collaborator

@mraible mraible commented Aug 24, 2022

Fixes #711.

@mraible mraible closed this Aug 31, 2022
@mraible mraible reopened this Aug 31, 2022
@mshima
Copy link
Member

mshima commented Aug 31, 2022

Migration to typed form can be trick, to skip it, you need to change from FormBuilder to UntypedFormBuilder.

@mraible
Copy link
Collaborator Author

mraible commented Aug 31, 2022

@mshima Doh! It looks like we both made changes at the same time. I'll let you continue since I'm more focused on the React Native blueprint right now.

@mshima
Copy link
Member

mshima commented Aug 31, 2022

@mraible no problem I just tried to help, I won't be working on this today.
I did not got the chance to add cypress to react native yet. I hope to do it soon.
I will probably need to reimplement to cleanup and follow v8 style like ionic, entity-audit, native. I am currently doing it at jooq, I though I would be easier.

@mraible
Copy link
Collaborator Author

mraible commented Sep 3, 2022

This PR is now failing because of Cypress:

Cypress version 10.0.0 no longer supports cypress.json.

Please run cypress open to launch the migration tool to migrate to cypress.config.{js,ts,mjs,cjs}.

https://on.cypress.io/migration-guide

@mraible
Copy link
Collaborator Author

mraible commented Sep 4, 2022

Tests seem to be failing at the Wait for backend to start step but only for a couple of jobs.

@mshima Did something change between 7.8.1 and 7.9.3 that would make it so the backend takes longer to start? I tried to reproduce locally but was unable to.

Update: If I look at the dumped Docker logs, it looks like the jhipster-registry is failing to start because it can't find Keycloak. I'll fix and try again.

@mraible
Copy link
Collaborator Author

mraible commented Sep 4, 2022

Now it seems like Keycloak is started after the other containers, so the app fails to find it when it starts.


> health-points@0.0.1-SNAPSHOT docker:app:up
> docker-compose -f src/main/docker/app.yml up -d

Creating network "docker_default" with the default driver
Pulling healthpoints-postgresql (postgres:14.5)...
14.5: Pulling from library/postgres
Digest: sha256:befb4cdc1d944bd89784b9caa287cf025f0720f9a02436038[12](https://github.com/jhipster/generator-jhipster-ionic/runs/8177780678?check_suite_focus=true#step:13:13)4163accd177dc
Status: Downloaded newer image for postgres:14.5
Pulling healthpoints-elasticsearch (docker.elastic.co/elasticsearch/elasticsearch:7.17.4)...
7.17.4: Pulling from elasticsearch/elasticsearch
Digest: sha256:b3fed35f7a43a3e16aa037bf9c8cb8[13](https://github.com/jhipster/generator-jhipster-ionic/runs/8177780678?check_suite_focus=true#step:13:14)9d1eec879ab56[16](https://github.com/jhipster/generator-jhipster-ionic/runs/8177780678?check_suite_focus=true#step:13:17)f3c20746484de4010
Status: Downloaded newer image for docker.elastic.co/elasticsearch/elasticsearch:7.[17](https://github.com/jhipster/generator-jhipster-ionic/runs/8177780678?check_suite_focus=true#step:13:18).4
Pulling keycloak (quay.io/keycloak/keycloak:[19](https://github.com/jhipster/generator-jhipster-ionic/runs/8177780678?check_suite_focus=true#step:13:20).0.1)...
19.0.1: Pulling from keycloak/keycloak
Digest: sha256:fb6be1665f2939ca123b5fee0d6d8e06a3d99ba1e5[22](https://github.com/jhipster/generator-jhipster-ionic/runs/8177780678?check_suite_focus=true#step:13:23)4b5b1cf0eb48168f1ef6
Status: Downloaded newer image for quay.io/keycloak/keycloak:19.0.1
Creating docker_healthpoints-app_1 ... 
Creating docker_keycloak_1         ... 
Creating docker_healthpoints-elasticsearch_1 ... 
Creating docker_healthpoints-postgresql_1    ... 
Creating docker_healthpoints-postgresql_1    ... done
Creating docker_healthpoints-app_1           ... done
Creating docker_healthpoints-elasticsearch_1 ... done
Creating docker_keycloak_1                   ... done

In the latest failure, the registry can't connect to Keycloak and the app can't connect to the registry. That's why the gateway app is failing.

@mshima
Copy link
Member

mshima commented Sep 4, 2022

New keycloak is taking a long time to start.
We will probably need change the docker compose file.

@mraible
Copy link
Collaborator Author

mraible commented Sep 4, 2022

Do we really need to test if Docker works in this project? I'd prefer to use the workflow I use in demos.

npm run ci:e2e:prepare
# Then, start the app with mvn or gradle

@mraible mraible marked this pull request as ready for review September 4, 2022 20:46
@mshima mshima merged commit cb7baaf into main Sep 4, 2022
@mshima mshima deleted the capacitor-4 branch September 4, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to use Capacitor 4
2 participants