Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Cypress files to follow standards #798

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Rename Cypress files to follow standards #798

merged 3 commits into from
Mar 30, 2023

Conversation

mraible
Copy link
Collaborator

@mraible mraible commented Mar 27, 2023

Fixes #718.

@mraible mraible requested a review from mshima March 28, 2023 04:21
mshima
mshima approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Should we implement migration?

generators/ionic/resources/base/cypress.config.ts Outdated Show resolved Hide resolved
@mraible
Copy link
Collaborator Author

mraible commented Mar 29, 2023

Should we implement migration?

This blueprint has never had an upgrade command, so I'm not sure it's necessary. We should definitely mention it in the release notes.

@mshima mshima merged commit 06463e3 into main Mar 30, 2023
@mshima mshima deleted the rename-cypress-files branch March 30, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename cypress files extension to cy.ts to follow cypress 10 and jhipster 7.9.3 standards
2 participants
@mraible @mshima