Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ESM. #19113

Closed
8 of 24 tasks
mshima opened this issue Jul 8, 2022 · 5 comments · Fixed by #20079
Closed
8 of 24 tasks

Switch to ESM. #19113

mshima opened this issue Jul 8, 2022 · 5 comments · Fixed by #20079
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: jhipster-internals v8 $500 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@mshima
Copy link
Member

mshima commented Jul 8, 2022

Overview of the feature request
  • app
  • base
  • bootstrap
  • bootstrap-application
  • ci-cd
  • client
  • common
  • cypress
  • database-changelog
  • database-changelog-liquibase
  • docker-compose
  • generate-blueprint
  • gradle
  • heroku
  • kubernetes
  • java
  • languages
  • maven
  • project-name
  • server
  • spring-boot
  • upgrade
  • workspaces
Motivation for or Use Case

Follow javascript standards

Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@Tcharl
Copy link
Contributor

Tcharl commented Dec 2, 2022

Reopened: the jhipster cli is not working anymore due to a dependecy to constants.cjs, which itself needs jdl/validation.mjs...

@mshima
Copy link
Member Author

mshima commented Dec 3, 2022

The generator has already switched to esm and every bit is esm except jdl and cli.

The cli problem is related to mocking, which I am working on.
The jdl can be switched except some definitions that the cli uses.

Please open a new issue to track cli and jdl switch to esm.

@mshima mshima closed this as completed Dec 3, 2022
@Tcharl
Copy link
Contributor

Tcharl commented Dec 3, 2022

The issue was labelled 'switch to ESM', thus wasn't mentioning that it was only targeting generator, still, the content did.

Why not reopening to get the complete picture? What's the added value of two tickets ?

I saw your current repo: great ambition which would really help, keep on rockin'! I'm trying through a simpler way, but not sure to succeed.

Best regards,

@mshima
Copy link
Member Author

mshima commented Feb 13, 2023

@DanielFran
Copy link
Member

@mshima approved

@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: jhipster-internals v8 $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants