Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to type modules. #19941

Merged
merged 36 commits into from
Oct 6, 2022
Merged

Switch to type modules. #19941

merged 36 commits into from
Oct 6, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Oct 6, 2022

Related to #19113.

  • change every test mts or mjs, keep mjs where there is too many unsafe type problems.
    Except jdl and cli tests, cli relies on proxyquire (commonjs only).
  • rename commons files to cjs.
  • change type to module at root package.json
  • add package.json with type commonjs to jdl and test/jdl folders.
  • move generator-base* to base/*
  • move docker-* to base-docker/*
  • use priority name from static fields. (Unambiguous Priorities #17132)

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit a975d8a into jhipster:main Oct 6, 2022
@mshima mshima deleted the skip_ci-working_tree branch November 23, 2022 13:33
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants