-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate JDL to typescript #19182
Comments
What do you think @deepu105 @MathieuAA? |
+1 |
However, TS won't be the holy grail. It can make things a bit more understandable but we need conventions for the whole project (for instance interfaces, what actually qualifies as an internal breaking change, etc.). |
Sure, can you take this ticket? |
@mshima Which part of JDL are you talking about exactly? There are many files related to JDL. That would be probably too much to do at once. I suggest to enable TS as a first step. Then smaller parts can be gradually migrated to TS. |
The entire jdl folder.
Sure can be split in several PRs or even issues, but the issue is to track the entire jdl support (folder). |
@mshima : I'm removing the bounty, following this https://www.jhipster.tech/bug-bounties/#how-bug-bounties-are-created And I'm putting back the bounty, as it's totally deserved. So plz, ping Daniel, Deepu, Julien or me, if you think a ticket needs one :-) |
If you all are serious about using TS instead of JS, then we need a clear strategy that:
Thus, we have to measure those:
The last point is to check whether TS is a good fit. |
I like so much prisma's schemes. Maybe it can be a source of inspiration. |
[skip ci] Resolve jhipster#19182
[skip ci] Resolve jhipster#19182
We should check with the author of the JHipster JDL plugin for IDEA. I'd hate for their hard work to be impacted by this change. |
I already worked on migrating some files to TS in #19558. So far it seems the code migration itself will be rather straightforward. But I think it might be better to just first configure the compilation and build of the project before working on migrating the code. I started to work on the configuration here: #19559
I am not sure in what regards this might be an inspiration. The ticket is about migrating the code of JDL from JavaScript to TypeScript. The JDL itself should not change. @MathieuAA @mraible |
@emilpaw I’ve managed to use mocha + |
A good way to migrate the project, JDL included, could be to:
This makes the migration process way easier and the review way easier too |
Overview of the feature request
JDL is quite complicated to understand and missing a few features.
We should migrate it to typescript to make it simpler and may receive more contributions.
Motivation for or Use Case
Improve developer experience.
Related issues or PR
The text was updated successfully, but these errors were encountered: