Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Footer cannot be translated in 8.0.0+ #24639

Closed
1 task done
OmarHawk opened this issue Dec 21, 2023 · 0 comments · Fixed by #24640
Closed
1 task done

Angular: Footer cannot be translated in 8.0.0+ #24639

OmarHawk opened this issue Dec 21, 2023 · 0 comments · Fixed by #24640

Comments

@OmarHawk
Copy link
Contributor

OmarHawk commented Dec 21, 2023

Overview of the issue

Language switch of footer doesn't work (it will always show the plain text). Import was forgotten, when migrating to standalone component.

Motivation for or Use Case

Everything should be translateable in the default UI.

Reproduce the error
  1. generate Application with at least two languages.
  2. start up
  3. try to switch language
  4. footer is not translated (but all the rest)
Related issues
Suggest a Fix

I'll prepare a PR.

JHipster Version(s)

8.1.0

JHipster configuration
.yo-rc.json file
{
  "generator-jhipster": {
    "applicationType": "monolith",
    "authenticationType": "oauth2",
    "baseName": "dataview",
    "buildTool": "maven",
    "cacheProvider": "no",
    "clientFramework": "angular",
    "clientTestFrameworks": [],
    "clientTheme": "none",
    "creationTimestamp": 1703162176971,
    "databaseType": "sql",
    "devDatabaseType": "mysql",
    "devServerPort": 4200,
    "enableGradleEnterprise": null,
    "enableHibernateCache": false,
    "enableSwaggerCodegen": false,
    "enableTranslation": true,
    "entities": [],
    "feignClient": false,
    "gradleEnterpriseHost": null,
    "jhipsterVersion": "8.1.0",
    "languages": [
      "de",
      "en"
    ],
    "messageBroker": false,
    "microfrontend": null,
    "microfrontends": [],
    "nativeLanguage": "de",
    "packageName": "de.markant.dataview",
    "prodDatabaseType": "mysql",
    "reactive": false,
    "searchEngine": "elasticsearch",
    "serverPort": null,
    "serverSideOptions": [
      "searchEngine:elasticsearch"
    ],
    "serviceDiscoveryType": false,
    "skipUserManagement": true,
    "testFrameworks": [],
    "websocket": false,
    "withAdminUi": true
  }
}
Environment and Tools

openjdk version "17.0.7" 2023-04-18 LTS
OpenJDK Runtime Environment (Red_Hat-17.0.7.0+7-1) (build 17.0.7+7-LTS)
OpenJDK 64-Bit Server VM (Red_Hat-17.0.7.0+7-1) (build 17.0.7+7-LTS, mixed mode, sharing)

git version 2.43.0.windows.1

node: v18.19.0
npm: 10.2.3

Docker version 24.0.2-rd, build e63f5fa

JDL for the Entity configuration(s) entityName.json files generated in the .jhipster directory
JDL entity definitions

Browsers and Operating System
  • Checking this box is mandatory (this is just to show you read everything)
OmarHawk added a commit to OmarHawk/generator-jhipster that referenced this issue Dec 21, 2023
so that it can be translated again

Fix jhipster#24639
OmarHawk added a commit to OmarHawk/generator-jhipster that referenced this issue Dec 21, 2023
so that it can be translated again

Fix jhipster#24639
mshima pushed a commit that referenced this issue Dec 21, 2023
so that it can be translated again

Fix #24639
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants