Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 2.26.0. CustomAccessDeniedHandler class is not being created during update. #2497

Closed
lluiscanals opened this issue Dec 17, 2015 · 12 comments
Milestone

Comments

@lluiscanals
Copy link
Contributor

  • Overview of the issue

When updating to jhipster 2.26.0 from 2.25.0 is created a new line of code in SecurityConfiguration class

http
            .exceptionHandling()
            .accessDeniedHandler(new CustomAccessDeniedHandler())  // This line is new!!!
            .authenticationEntryPoint(authenticationEntryPoint)

But the problem is that the class file is not being created.

  • Motivation for or Use Case

    Updating a hjipster app.

  • JHipster Version(s)

    2.26.0

  • JHipster configuration, a .yo-rc.json file generated in the root folder

    {
    "generator-jhipster": {
    "baseName": "test",
    "packageName": "com.mycompany.myapp",
    "packageFolder": "com/mycompany/myapp",
    "authenticationType": "xauth",
    "hibernateCache": "ehcache",
    "clusteredHttpSession": "no",
    "websocket": "no",
    "databaseType": "sql",
    "devDatabaseType": "mysql",
    "prodDatabaseType": "mysql",
    "searchEngine": "elasticsearch",
    "useSass": false,
    "buildTool": "maven",
    "frontendBuilder": "grunt",
    "enableTranslation": true,
    "enableSocialSignIn": false,
    "rememberMeKey": "",
    "testFrameworks": [
    "gatling",
    "protractor"
    ]
    }
    }

  • Entity configuration(s) entityName.json files generated in the .jhipster directory

  • Browsers and Operating System
  • Reproduce the error

    Update an app to jhipster 2.26.0

  • Related issues
  • Suggest a Fix
@jdubois
Copy link
Member

jdubois commented Dec 17, 2015

Thanks a lot!!!!!
I don't know how this could have passed our Travis build @pascalgrimaud ???
Let's do an emergency new release

@lluiscanals
Copy link
Contributor Author

You are welcome. Glad to help!

@pascalgrimaud
Copy link
Member

Strange, no error in Travis Log for mvn test / grunt test, and the app starts with mvn spring-boot:run
I will check this !

@jdubois
Copy link
Member

jdubois commented Dec 17, 2015

Thanks really! Now I understand why it did pass the Travis build: we don't test the XAuth option!!

@jdubois
Copy link
Member

jdubois commented Dec 17, 2015

@pascalgrimaud I'm adding a Docker build for this -> I need to learn what you did so that's a good exercise!!

jdubois added a commit that referenced this issue Dec 17, 2015
@pascalgrimaud
Copy link
Member

Yes ok ! All options are not tested (for example Hazelcast). I tried to cover a lot of combinaisons and we can go on to improve it.

@jdubois
Copy link
Member

jdubois commented Dec 17, 2015

Then we will also need Hazelcast :-)
Yes let's add more options, it's free anyway... Thanks a lot Travis, as all those builds should cost a good amount of money!!

@jdubois jdubois modified the milestone: 2.26.1 Dec 17, 2015
@lluiscanals
Copy link
Contributor Author

Can you confirm it is working? I have made the update with 2.26.1 and the class is not created :(
I'm implementing by hand for now.

Regards!

@jdubois
Copy link
Member

jdubois commented Dec 17, 2015

This is normal: this class is only for CSRF protection and with a stateless autenth you do not need this.
So it's the line in the configuration file which should be deleted.

@rakishmu
Copy link

hi. can anyone help me ? how to upgrade from version 2.25.0 ? because i already development using that one.

@pascalgrimaud
Copy link
Member

Look at http://jhipster.github.io/2015/12/17/jhipster-release-2.26.1.html
Don't forget to commit or create branch with git before trying to update to latest version
So you'll be able to rollback

@rakishmu
Copy link

@pascalgrimaud thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants