-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from spring-kafka to native Apache Kafka client #10379
Conversation
d293f75
to
1860721
Compare
6f536ef
to
92d0ad3
Compare
generators/server/templates/src/main/java/package/service/KafkaConsumer.java.ejs
Outdated
Show resolved
Hide resolved
generators/server/templates/src/main/java/package/service/KafkaProducer.java.ejs
Outdated
Show resolved
Hide resolved
<%_ if (messageBroker === 'kafka') { _%> | ||
kafka: | ||
consumer: | ||
key.deserializer: org.apache.kafka.common.serialization.StringDeserializer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you updated the properties here, you need to do the same for :
- local app.yml
- docker-compose sub gen
- kubernetes sub gen
- openshift sub gen
- etc
generators/server/templates/src/test/java/package/web/rest/KafkaResourceIT.java.ejs
Outdated
Show resolved
Hide resolved
Just tested and it works ! Really great job @ctamisier The most important missing part is the properties in YAML files for docker-compose, k8s etc. |
Thanks for the review ! |
@ctamisier : don't hesitate to ping me as soon as you update this PR, so I can have a look again. If you don't have time, just tell me, I'll help you to update this, as I'd like to have this for the next release and start contribution on the entity part + Kafka |
c72ca84
to
d39c2fe
Compare
Since your last review I applied the following changes:
I'm not really good about docker compose file definition... I tried to make I don't know what We still need to adjust app.yml.ejs (I've an issue now because I use Your help @pascalgrimaud is really welcome, I'm kind of learning docker-compose right now and I might not have the "Best Practices" to apply on this part. |
ok @ctamisier |
Just done the review and the tests. good job @ctamisier and @clement26695 ! @ctamisier : plz, don't rebase / force push, otherwise, we will lost our work here :) |
PR candidate for fixing #9287