fix sonar issues for core application and entities #10559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomfrede
changed the title
vishal423
requested changes
Oct 5, 2019
...t/templates/angular/src/main/webapp/app/admin/configuration/configuration.component.html.ejs
Outdated
Show resolved
Hide resolved
generators/client/templates/angular/src/main/webapp/app/admin/logs/logs.component.html.ejs
Outdated
Show resolved
Hide resolved
...rators/client/templates/angular/src/main/webapp/app/admin/tracker/tracker.component.html.ejs
Outdated
Show resolved
Hide resolved
...mplates/angular/src/main/webapp/app/admin/user-management/user-management.component.html.ejs
Outdated
Show resolved
Hide resolved
...y-client/templates/angular/src/main/webapp/app/entities/entity-management.component.html.ejs
Outdated
Show resolved
Hide resolved
atomfrede
force-pushed
the
10258-fix-sonar-issues
branch
2 times, most recently
from
1768d3b
to
e9f7084
Compare
atomfrede
force-pushed
the
10258-fix-sonar-issues
branch
from
e9f7084
to
df970c0
Compare
vishal423
approved these changes
Oct 7, 2019
|
thanks @atomfrede |
4 tasks
|
Will have a look into the remaining more or less false positives ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get our sonar rating forward this PR replaces #10263
updates #10258
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed