[angular] Reduce event manager importance and usage #13111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there is not possible to apply strict type checking if using event manager then this usage should not be encouraged. So moved this to util subfolder instead of separate folder and put model to the same file where is service to reduce event manager visibility and importance. Added also strict types instead of any to event manager. Now consumers must do type cast - so if they use event manager they take a conscious risk. Added block "unreleased files and folders cleanup for v7 developers" to cleanup to delete files if developers regenerate with newer version in v7 development cycle.
|
@kaidohallik no problem, will close the other PR. |
5 tasks
qmonmert
reviewed
Nov 21, 2020
| import { <%_ if (pagination !== 'no') { _%>HttpHeaders, <% } %>HttpResponse } from '@angular/common/http'; | ||
| <%_ if (pagination === 'pagination') { _%> | ||
| import { ActivatedRoute, Router } from '@angular/router'; | ||
| import { combineLatest } from 'rxjs'; |
There was a problem hiding this comment.
Looks right. Wondering why eslint didn’t complained.
There was a problem hiding this comment.
This is used in pagination-template, so this import is needed and is under right condition.
This is migrated from deleted row below.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up to #13096 - after thinking deeper about event manager and using ideas from #13073.
As there is not possible to apply strict type checking if using event manager then this usage should not be encouraged. So moved this to
utilsubfolder instead of separate folder and put model to the same file where is service to reduce event manager visibility and importance.Added also strict types instead of
anyto event manager. Now consumers must do type cast - so if they use event manager they take a conscious risk.Added block "unreleased files and folders cleanup for v7 developers" to cleanup to delete files if developers regenerate with newer version in v7 development cycle.
This PR has 3 commits:
@DanielFran : last commit in this PR is related to your PR #13073 - it basically implements suggestion from #13073 (comment), if you disagree with last commit and want to do changes yourself then I can drop last commit and let this to you.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.