[angular] Angular fixes and polishing, noticed while creating test refactor branch #13149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating test refactor branch https://github.com/kaidohallik/generator-jhipster/tree/refactor-angular-tests noticed some problems. This PR fixes them. Contains 4 commits:
Follow up to [angular] Reduce event manager importance and usage #13111 which forgot to add
catch
block toPromise
in delete dialog close which caused console error in delete rejection. Now replacedPromise
withObservable
(available fromng-bootstrap
v8). Added comment about why not unsubscribing to give confidence that no memory leak here.Follow up to ng-jhipster migration to generator-jhipster #13022 which put metrics blocks into metrics root folder, it makes metrics folder difficult to read. Now fixed that by moving blocks into
blocks
subfolder.Add missing license headers.
Polish imports.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.