Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular] Angular fixes and polishing, noticed while creating test refactor branch #13149

Merged
merged 4 commits into from
Nov 29, 2020

Conversation

kaidohallik
Copy link
Contributor

While creating test refactor branch https://github.com/kaidohallik/generator-jhipster/tree/refactor-angular-tests noticed some problems. This PR fixes them. Contains 4 commits:

  • Follow up to [angular] Reduce event manager importance and usage #13111 which forgot to add catch block to Promise in delete dialog close which caused console error in delete rejection. Now replaced Promise with Observable (available from ng-bootstrap v8). Added comment about why not unsubscribing to give confidence that no memory leak here.

  • Follow up to ng-jhipster migration to generator-jhipster #13022 which put metrics blocks into metrics root folder, it makes metrics folder difficult to read. Now fixed that by moving blocks into blocks subfolder.

  • Add missing license headers.

  • Polish imports.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielFran DanielFran merged commit 78caaa6 into jhipster:main Nov 29, 2020
@kaidohallik kaidohallik deleted the polish-angular branch November 29, 2020 15:23
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants