Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vue entities translation keys create, update, delete #13393

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

swarajsaaj
Copy link
Contributor

@swarajsaaj swarajsaaj commented Jan 1, 2021

In microservices applications, vue uses keys with prefix as
'microserviceAppName.translationKey' rather than
'frontendAppName.translationKey'. This commit fixes the key using a new
variable i18nAssetHeaderPrefix for entities.

Fix #13384


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

In microservices applications, vue uses keys with prefix as
'microserviceAppName.translationKey' rather than
'frontendAppName.translationKey'. This commit fixes the key using a new
variable i18nAssetHeaderPrefix for entities.

Fix jhipster#13384
Copy link
Member

@atomfrede atomfrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swarajsaaj

@atomfrede atomfrede merged commit dee97e9 into jhipster:main Jan 7, 2021
@swarajsaaj
Copy link
Contributor Author

@pascalgrimaud
Copy link
Member

@swarajsaaj : approved

@swarajsaaj
Copy link
Contributor Author

Thanks @pascalgrimaud

@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.1 milestone Jan 16, 2021
coderguy-tech pushed a commit to coderguy-tech/generator-jhipster that referenced this pull request Jun 1, 2021
)

In microservices applications, vue uses keys with prefix as
'microserviceAppName.translationKey' rather than
'frontendAppName.translationKey'. This commit fixes the key using a new
variable i18nAssetHeaderPrefix for entities.

Fix jhipster#13384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A microservices architecture with Vue doesn't have translations in alerts
3 participants