-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password reset feature #508 #1343
Conversation
Yay! Thanks for the work. I look forward to when it is merged into a release. |
That's a huge work, thanks!!! |
Take your time, better to have a great implementation than having to create a lot patches afterwards. |
Great feature and great work! |
@gmarziou Sounds like a great idea. Will think about how to implement it. |
@atomfrede you forgot to add the email reset template, so when the email is sent we have an error, can you add that file? |
@jdubois Oh sorry :( Will add it today. |
ng-show="form.confirmPassword.$error.minlength" translate="global.messages.validate.confirmpassword.minlength"> | ||
Your password confirmation is required to be at least 5 characters | ||
</p> | ||
<p class="help-block" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could simplify markup for confirmation password by removing min and max length messages as this is already covered for password and matching both.
@gmarziou Guess you're right, just copied the registration form in fact |
@@ -5,3 +5,15 @@ angular.module('<%=angularAppName%>') | |||
return $resource('api/account/change_password', {}, { | |||
}); | |||
}); | |||
|
|||
angular.module('jhipsterApp') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jhipsterApp should be <%=angularAppName%>
Maybe you should consider just chaining the 3 calls to factory().
Merged with dbe65a6 |
A proposal for the long wanted password reset feature :)
The rest works as follows (see #508 for details):