-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Couchbase support for Spring Boot 2.4 #13770
Conversation
These serious bugs are already fixed in 4.1.0-M1 so we used that version until 4.0.2 is released
…Repository that provides the same methodes
Solves CI error: 'dependencies.dependency.version' for com.couchbase.client:encryption:jar is missing. @ line 151, column 21
generators/entity-server/templates/src/main/java/package/domain/Entity.java.ejs
Outdated
Show resolved
Hide resolved
generators/entity-server/templates/src/main/java/package/domain/Entity.java.ejs
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
generators/entity-server/templates/src/main/java/package/domain/Entity.java.ejs
Outdated
Show resolved
Hide resolved
generators/entity-server/templates/src/main/java/package/domain/Entity.java.ejs
Outdated
Show resolved
Hide resolved
ejs problem is fixed. |
It seems like there's a lot to do to upgrade to Spring Data Couchbase 4.x. I give up and will add a bug bounty to the open issue for this PR. |
You can use JHipster Daily Builds + the Couchbase job to trigger a build for your branch. If you don't have access, please let me know and I can trigger it for you. |
Couchbase is completely broken, but we should merge to fix ejs template. |
I merged in @murdos' changes. Testcontainers doesn't seem to like the Docker container.
I tried changing it from
|
This seems to fix the issue, but there's still a lot of test failures.
|
Down to 9 test failures for the
Time for a bike ride. :) |
Now we're at 6 failures and 1 error after the last commit that adds
|
I think if we could configure default consistency for tests, we could fix a lot of these failures. This SO question makes it look like it was possible in previous versions. |
...r/templates/src/main/java/package/config/couchbase/CustomCouchbaseRepositoryFactory.java.ejs
Outdated
Show resolved
Hide resolved
...mplates/src/main/java/package/config/couchbase/CustomCouchbaseRepositoryFactoryBean.java.ejs
Outdated
Show resolved
Hide resolved
...ver/templates/src/main/java/package/config/couchbase/CustomCouchbaseRepositoryQuery.java.ejs
Outdated
Show resolved
Hide resolved
...tors/server/templates/src/main/java/package/config/couchbase/CustomN1qlQueryCreator.java.ejs
Outdated
Show resolved
Hide resolved
...tors/server/templates/src/main/java/package/config/couchbase/CustomN1qlQueryCreator.java.ejs
Outdated
Show resolved
Hide resolved
...tors/server/templates/src/main/java/package/config/couchbase/CustomN1qlQueryCreator.java.ejs
Outdated
Show resolved
Hide resolved
...tors/server/templates/src/main/java/package/config/couchbase/CustomN1qlQueryCreator.java.ejs
Outdated
Show resolved
Hide resolved
...tors/server/templates/src/main/java/package/config/couchbase/CustomN1qlQueryCreator.java.ejs
Outdated
Show resolved
Hide resolved
...tors/server/templates/src/main/java/package/config/couchbase/CustomN1qlQueryCreator.java.ejs
Outdated
Show resolved
Hide resolved
.../templates/src/main/java/package/config/couchbase/CustomN1qlRepositoryQueryExecutor.java.ejs
Outdated
Show resolved
Hide resolved
There's still a lot of tests failing for the reactive implementation of Couchbase:
Test run using daily builds: https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/538490717 |
Do we need to set up testcontainers to support utf-8 for PostgreSQL? Error from webflux-psql job:
|
Closing and reopening to run CI again. |
I had to re-create this PR because I deleted my fork. See #14184. |
Fixes #13544.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.