Save() operation doesn't seem to be synchronous [DATACOUCH-589]

[spring-projects-issues]

murdos opened DATACOUCH-589 and commented

Using a non reactive repository, the following code in an integration test randomly fail, which make me think that then entity is not always saved when the save() method returns:

// Initialize the database
userRepository.save(user);
int databaseSizeBeforeCreate = userRepository.findAll().size();

assumeThat(databaseSizeBeforeCreate).isEqualTo(1); // assumption randomly fail with databaseSizeBeforeCreate being equal to 0

---

Affects: 4.1 M2 (2020.0.0)

[spring-projects-issues]

murdos commented

BTW, if you need a test case, this is the UserResourceIT in https://github.com/murdos/react-maven-couchbase-caffeine-sb23

And FYI I desperately try to upgrade JHipster to Spring Data Couchbase 4, and Couchbase support is currently blocking the whole upgrade to Spring Boot 2.3 in JHipster

[spring-projects-issues]

Michael Reiche commented

hi @murdos -
Any find*() method that is not *ById requires the items be indexed by the indexer before they are found.  To ensure that the indexer has ran on the new document, you can specify ScanConsistency on the repository method:

@Override
@ScanConsistency(query = QueryScanConsistency.REQUEST_PLUS)
Flux<User> findAll();

Alternatively, if you  use findById( ), it should return the new document immediately even without @ScanConsistency
There is a recently fixed bug where ScanConsistency was being ignored on count() methods (DATACOUCH-585)

[mraible]

@mikereiche I'm trying to pick up where @murdos left off and upgrade JHipster's Couchbase support to work with Spring Boot 2.4.2. You can see my in-progress PR here.

I feel like I'm overriding methods all over and added the following everywhere.

@ScanConsistency(query = QueryScanConsistency.REQUEST_PLUS)

However, I only really need this for tests, so it seems kinda weird.

Is there a mechanism in Spring Data Couchbase to make things strongly consistent like previous versions had? I'd only like it for tests so we can add/retrieve data successfully.

From https://stackoverflow.com/q/54897120/65681:

@TestConfiguration
@Slf4j
@Order(0)
public class TestCouchbaseConfig extends AbstractCouchbaseConfiguration {

    ...

    @Override
    protected Consistency getDefaultConsistency() {
        return Consistency.STRONGLY_CONSISTENT; //READ_YOUR_OWN_WRITES|UPDATE_AFTER ... etc;
    }
}

[mikereiche]

The getDefaultConsistency() method is gone from the AbstractCouchbaseConfiguration. I don't know why.
It could be added back, or we could introduce a Class-level @ScanConsistency annotation.

[mraible]

In my experience with JHipster, we only need it for testing, so setting it globally in one place (e.g., a test configuration class) is my favorite option. I'm not sure we need it on the method or class level because all our e2e tests (with Cypress) pass w/o it.