-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for force-insights option #14485
Add support for force-insights option #14485
Conversation
* feat: add force-insights back in This option needs to be supported. Ideally we should fix this in the generator. * feat: disable stats until jhipster/generator-jhipster#14485 is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option is correct.
The text should match --no-insight
, so change it to Disable the insights
.
IMO it could lose the the
.
Somehow we have missed supporting the force-insights option. This adds the force-insights option back to the generator.
d19b117
to
e54849d
Compare
@mshima : Thanks for the review. I've just pushed that (remove |
Somehow we have missed supporting the force-insights option. This adds the force-insights option back to the generator. Otherwise passing this option results in a error;
JHipster Online is also effected by this error which I've opened a PR as well; jhipster/jhipster-online#291
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.