Add support for force-insights option #14485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SudharakaP
added a commit
to SudharakaP/jhipster-online
that referenced
this pull request
Mar 27, 2021
SudharakaP
added a commit
to jhipster/jhipster-online
that referenced
this pull request
Mar 27, 2021
* feat: add force-insights back in This option needs to be supported. Ideally we should fix this in the generator. * feat: disable stats until jhipster/generator-jhipster#14485 is fixed
SudharakaP
added a commit
to SudharakaP/jhipster-online
that referenced
this pull request
Mar 27, 2021
mshima
approved these changes
Mar 27, 2021
Somehow we have missed supporting the force-insights option. This adds the force-insights option back to the generator.
SudharakaP
force-pushed
the
feat/add-support-for-force-insights-option
branch
from
d19b117
to
e54849d
Compare
@mshima : Thanks for the review. I've just pushed that (remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow we have missed supporting the force-insights option. This adds the force-insights option back to the generator. Otherwise passing this option results in a error;
JHipster Online is also effected by this error which I've opened a PR as well; jhipster/jhipster-online#291
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.