Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use derived constants in entity-server templates and domain #14659

Merged
merged 7 commits into from
Apr 15, 2021

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Apr 12, 2021

Contributes to #14235


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl Tcharl force-pushed the constantref branch 4 times, most recently from 51083a2 to 14fcac5 Compare April 13, 2021 09:06
utils/entity.js Outdated Show resolved Hide resolved
@Tcharl Tcharl force-pushed the constantref branch 3 times, most recently from 08bdf31 to d6df28a Compare April 13, 2021 20:51
@Tcharl
Copy link
Contributor Author

Tcharl commented Apr 14, 2021

Hi @DanielFran @mshima good to go?

@mshima
Copy link
Member

mshima commented Apr 14, 2021

@Tcharl let me handle the autoGenerate first.
Working on it now.

@mshima mshima mentioned this pull request Apr 14, 2021
5 tasks
@mshima
Copy link
Member

mshima commented Apr 14, 2021

@Tcharl done #14679.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting changes related to #14679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants