Improve autoGenerate logic. #14679
Merged
Improve autoGenerate logic. #14679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Tcharl
reviewed
Apr 14, 2021
| field.liquibaseAutoIncrement = false; | ||
| field.jpaGeneratedValue = false; | ||
| field.autoGenerateByService = field.fieldType === UUID; | ||
| field.autoGenerateByRepository = !field.autoGenerateByService; |
There was a problem hiding this comment.
I mean, a not is acceptable in a template, the illustration is that you use f => !f.autoGenerateByRepository instead of its service counterpart in your PR :-p.
Choose you poison, but keep only one please (if there is a vote, I would choose the autoGenerateByServiceone, as it is the less standard)
There was a problem hiding this comment.
They are different:
f => !f.autoGenerateByRepository should be f => !f.autoGenerate || f.autoGenerateByService
If you still think it's better remove one of them, I can do it.
|
Good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #14659 and #14108
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.