Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generated files snapshot test for kubernetes. #14852

Merged
merged 3 commits into from
May 13, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented May 2, 2021

Deployment test suites currently tests:

  • generated file names.
  • a few generated contents.

There is no real execution tests and generated contents coverage is too low.

This PR implements generated files snapshot tests for kubernetes.

  • A full generated content regression test.

Old tests are kept for now but could be dropped.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member Author

mshima commented May 2, 2021

@Tcharl, with this we can merge #14767 with confidence.

After merged, I will migrate others deployment test to snapshot.

@Tcharl
Copy link
Contributor

Tcharl commented May 2, 2021

Looks correct :-). I get your point @mshima , to be honest I generated and regenerated my PR with the different options, but even with that my knees are knocking

@mshima should I merge?

@atomfrede
Copy link
Member

@mshima Looks good. Can you resolve the conflicts?

@mshima mshima changed the title Implement generated files snapshot test for heroku. Implement generated files snapshot test for kubernetes. May 12, 2021
@mshima mshima merged commit 4428eae into jhipster:main May 13, 2021
@mshima
Copy link
Member Author

mshima commented May 13, 2021

2 positive reviews, merged.

@mshima mshima deleted the skip_ci-snapshot branch May 13, 2021 10:05
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants