Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot test to others generators. #15005

Merged
merged 2 commits into from
May 17, 2021
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented May 15, 2021

Following #14852.

This PR adds snapshot tests to others generators that don't have regression tests in CI.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima requested a review from Tcharl May 15, 2021 15:00
@mshima
Copy link
Member Author

mshima commented May 15, 2021

@Tcharl snapshot tests for the others generators.
It took some time but it would be hard to fix regressions in deployments generators.

@Tcharl
Copy link
Contributor

Tcharl commented May 16, 2021

Awesome!
Would it be interesting to generalize snapshot testing? Looks like it will dramatically harden the jhipster tests as well as simplify their maintenance (total coverage can become a no-brainer: one file + all the combinations of options it uses == as many tests).
WDYT?

@mshima
Copy link
Member Author

mshima commented May 16, 2021

Would it be interesting to generalize snapshot testing?

Some generators generates too much code, and the files would be too big.

Follow-ups:

@mshima mshima merged commit 899e5df into jhipster:main May 17, 2021
@mshima mshima deleted the skip_ci-snapshot branch May 17, 2021 00:30
@Tcharl
Copy link
Contributor

Tcharl commented May 17, 2021

Could be nice for liquibase/incremental: I encountered some issues with some ids and relationships.
Big +1 for expected files of course: free food :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants