Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spring-boot version to 2.4.6 and other dependencies #15057

Merged
merged 16 commits into from
May 21, 2021

Conversation

DanielFran
Copy link
Member


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran added area: enhancement 🔧 theme: dependencies Pull requests that update a dependency file labels May 20, 2021
@@ -57,19 +61,19 @@ cassandraDriverVersion=4.9.0

# gradle plugin version
jibPluginVersion=<%= JIB_VERSION %>
gitPropertiesPluginVersion=2.2.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this works. In another project it still didn't work, so I had to stick with 2.2.4.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I remember when I try updating to 2.3.0... Just waiting that versions are available in maven server to validate it

@mraible
Copy link
Contributor

mraible commented May 21, 2021

Now that Spring Boot 2.5 is out, maybe that should be a priority over this upgrade?

@DanielFran
Copy link
Member Author

It is my next step

@DanielFran
Copy link
Member Author

@mraible Actually CI is too unstable to try 2.5.0
Just waiting that issue with eslint is fixed to try the upgrade

@mraible
Copy link
Contributor

mraible commented May 21, 2021

@DanielFran If there's anything I can do to help, please let me know.

@DanielFran
Copy link
Member Author

No, I'm in contact with @mshima with his workaround #15059 to temporally merge it to test this PR and next with spring-boot 2.5.0.
Too lazy to test all combination locally... :P

@DanielFran DanielFran closed this May 21, 2021
@DanielFran DanielFran reopened this May 21, 2021
@DanielFran DanielFran closed this May 21, 2021
@DanielFran DanielFran reopened this May 21, 2021
@DanielFran DanielFran marked this pull request as ready for review May 21, 2021 21:12
@DanielFran DanielFran merged commit 06361ad into jhipster:main May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants