Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround npm bug. #15059

Merged
merged 2 commits into from
May 21, 2021
Merged

Workaround npm bug. #15059

merged 2 commits into from
May 21, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented May 20, 2021


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran
Copy link
Member

@mshima Can we merge it temporally so we can proceed with other updates?

@mshima mshima marked this pull request as ready for review May 21, 2021 13:35
@mshima
Copy link
Member Author

mshima commented May 21, 2021

@DanielFran sure. I couldn’t identify the microservice error yet.

@DanielFran
Copy link
Member

@mshima I relaunch JDL tests, but it did not show what error was on CI

@mshima
Copy link
Member Author

mshima commented May 21, 2021

@mshima I relaunch JDL tests, but it did not show what error was on CI

Yep, I couldn’t reproduce locally

@mshima
Copy link
Member Author

mshima commented May 21, 2021

I got the log from https://github.com/jhipster/generator-jhipster/runs/2632960371.

Looks like an infinite recursion.

@mshima mshima merged commit 119cedf into jhipster:main May 21, 2021
@mshima mshima deleted the skip_ci-workaround_angular branch May 21, 2021 17:41
@mshima
Copy link
Member Author

mshima commented May 21, 2021

@DanielFran done.

@DanielFran
Copy link
Member

Thanks @mshima closed/reopen PRs to test it...

@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants