Improve composing of new generators and tests. #15618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tcharl
reviewed
Jul 9, 2021
generators/project-name/config.js
Outdated
| @@ -29,4 +35,4 @@ const defaultConfig = { | |||
| ...requiredConfig, | |||
| }; | |||
|
|
|||
| module.exports = { requiredConfig, defaultConfig }; | |||
| module.exports = { requiredConfig, defaultConfig, reproducibleConfig }; | |||
There was a problem hiding this comment.
idempotentConfig? defaultConfig? subGeneratorConfig?
There was a problem hiding this comment.
- requiredConfig needs to be written to .yo-rc.json.
- defaultConfig is not written to .yo-rc.json to keep it clean.
- reproducibleConfig is for testing purpose.
There was a problem hiding this comment.
Should requiredConfig be merged into defaultConfig and save everything?
What names?
There was a problem hiding this comment.
Guys, instead of naming them this way, we should be naming them by their actual function, not just their properties: how should each variable be used? For example, is it for tests? "testConfig" can be used, or "configForTests".
There was a problem hiding this comment.
Not every test should use it.
reproducibleConfigForTests would be better.
There was a problem hiding this comment.
That'd be a better name indeed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many methods must be switched from sync to async in other to support ESM blueprints.
The first queues the composed generator before current one, the later queues after current one.
jhipster addcommand shortcut is planned.Related to #15490
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.