-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add microfrontend support to vue. #16880
Conversation
Just missing entities-menu test. |
I'll look into this as soon as I can. It might take until Monday. |
@pascalgrimaud I think this is not a breaking change. Anyway, if you want I can try to make more changes optional to microfrontend. IMO breaking changes to JHipster should be jdl, the generators and some generated source features, not the source itself.
|
@mraible I've always used reused https://github.com/mshima/generator-jhipster/blob/main/test-integration/jdl-samples/blog-store/blog-store.jdl and used generator-jhipster/jdl/jhipster/default-application-options.js Lines 172 to 176 in dffe240
|
@mraible jdl should be fixed now. |
I tried it again a few minutes ago. If I just start the gateway and store, the gateway UI fails because it can't find blog. Is that expected? I think it'd be nice if you could just start the gateway + the microservice you want to work on. If I start the blog app, everything works fine. However, the blog's i18n translations don't seem to come through. They work fine on the product entity. |
You can start the gateway and use the microservice frontend standalone.
That's weird, if store app (product) works, blog app should work too. |
Did another try, and I've managed to workaround the missing remote.
Indeed, microservice translations of one app was been loaded before the gateway and been overridden. |
I'm testing this again with the latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find where the index.html message is set, but I think we should change it from:
To:
|
Ought I've removed |
Vue modularization for microservice:
Webpack:
webpack serve --mode production
Microfrontend details:
I've tried different approaches to lazy load without success.
microservice/entity
instead of justentity
. Examplehttp://localhost:8080/blog/post
.Closes #16276.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.