-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .npmrc to force npm to use bash. #18936
Conversation
@mshima it will be needed to put back windows tests using prod profile? |
@DanielFran prod tests won’t work because they need docker now. |
Puh, this took me a few hours to figure out that this here may be the reason the new version actually broke my local build on Windows, which was previously working and was set up with the default. In my scenario, this change here now makes use of wsl bash, which does not work properly for me, as "bash -c node" will fail, due to the non-interactive shell not having access to PATH properly by default: https://unix.stackexchange.com/questions/439151/passing-command-to-bash-from-cmd-exe-wsl-not-working I "fixed" this now by removing the entry in the generated local .npmrc for now. Maybe this is some local mis-configuration of my wsl or some co-incidential changes on another place, idk, but in case someone else has the same trouble, this could serve as a starting point for trouble-shooting. For me, stuff is working again. ;-) FYI: This is how the output is looking like then when the build is starting right after generation of the application:
I think, this is something worth mentioning in release notes, don't know, how many people this will affect. ;-) |
Should fix windows ci https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/2507832622.
We use './mvnw' which, is not compatible with cmd, force npm to use bash instead.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.