-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use absolute path for static images. #20617
Conversation
Thanks for the contribution. If possible it would be great to update react and vue as well. |
done. |
Can you check why the compilation fails for react and vue with |
I'll check vue & react in a few days after the hollidays. |
Fixed React changing the css-loader options, like Vue |
@CGarces I restarted the failied build, but it looks good, all other vue related pipelines are ok. Can you check the conflict? I think afterwards this is fine for merge |
With relative paths files are hashed, and cause miss hit from caches
I have rebased the PR. |
With relative paths files are hashed, and cause miss hit from caches, in my case I'm using a CDN.
Related to jhipster/jhipster.github.io#1248
I have changed and tested the angular application. Please confirm if I should modify also the other web frameworks.Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.