Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path for static images. #20617

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Use absolute path for static images. #20617

merged 1 commit into from
Jan 18, 2023

Conversation

CGarces
Copy link
Contributor

@CGarces CGarces commented Dec 16, 2022

With relative paths files are hashed, and cause miss hit from caches, in my case I'm using a CDN.

Related to jhipster/jhipster.github.io#1248

I have changed and tested the angular application. Please confirm if I should modify also the other web frameworks.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@atomfrede
Copy link
Member

Thanks for the contribution. If possible it would be great to update react and vue as well.

@CGarces
Copy link
Contributor Author

CGarces commented Dec 19, 2022

done.

@atomfrede
Copy link
Member

Can you check why the compilation fails for react and vue with Can't resolve '/content/images/jhipster_family_member_1.svg'

@DanielFran DanielFran closed this Dec 24, 2022
@DanielFran DanielFran reopened this Dec 24, 2022
@CGarces
Copy link
Contributor Author

CGarces commented Dec 24, 2022

I'll check vue & react in a few days after the hollidays.

@CGarces
Copy link
Contributor Author

CGarces commented Dec 28, 2022

Fixed VUE, but after the change relative urls on CSS no longer works.
If not is the desire behavior I can revert it and keep VUE as is, images are hashed or duplicates in the worse case.

Before the change
image
image

After the change

image

@CGarces
Copy link
Contributor Author

CGarces commented Dec 28, 2022

Fixed React changing the css-loader options, like Vue

@atomfrede
Copy link
Member

@CGarces I restarted the failied build, but it looks good, all other vue related pipelines are ok. Can you check the conflict? I think afterwards this is fine for merge

With relative paths files are hashed, and cause miss hit from caches
@CGarces
Copy link
Contributor Author

CGarces commented Jan 17, 2023

I have rebased the PR.
I can't Identify the root cause for the error at https://github.com/jhipster/generator-jhipster/actions/runs/3794496601/jobs/6626003614
Last build has failed due a timeout at https://github.com/jhipster/generator-jhipster/actions/runs/3942797909/jobs/6746876977

@Tcharl Tcharl merged commit 14d766b into jhipster:main Jan 18, 2023
@CGarces CGarces deleted the fix_static_content branch January 18, 2023 10:22
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants