Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert cli to esm #20657

Merged
merged 21 commits into from
Dec 23, 2022
Merged

Convert cli to esm #20657

merged 21 commits into from
Dec 23, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Dec 22, 2022


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

cli/import-jdl.mjs Outdated Show resolved Hide resolved
@Tcharl
Copy link
Contributor

Tcharl commented Dec 23, 2022

Awesome! Thank you so much: the internals of esm are so hard to get.
Why is it WIP? not ready to merge?

@mshima
Copy link
Member Author

mshima commented Dec 23, 2022

Still needs some work.

@mshima mshima marked this pull request as ready for review December 23, 2022 22:11
@mshima
Copy link
Member Author

mshima commented Dec 23, 2022

Further improvements can be done later.
Should be ready now.

@DanielFran DanielFran merged commit dcd5624 into jhipster:main Dec 23, 2022
@mshima mshima deleted the cli_ESM_secondtry branch February 4, 2023 14:27
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants