-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove 'false' option for servicediscovery, websocket, messageBroker and searc… #20664
Conversation
defd41f
to
4993028
Compare
c156fef
to
61697fc
Compare
61697fc
to
a911050
Compare
Looks like it also fixes a bug on searchEngine :-) |
@DanielFran who to review this one? |
dac9cf3
to
ac0d2d7
Compare
Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
2996c5a
to
b46ad79
Compare
b46ad79
to
bc94e43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exporting a wrapper object instead of using named exports is a bad practice it breaks esm lazy nature.
ace7e0d
to
f860423
Compare
f860423
to
db2a449
Compare
@Tcharl it will be needed to update documentation too, like in https://www.jhipster.tech/jdl/applications#options-in-applications |
Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
@DanielFran documentation PR is done: jhipster/jhipster.github.io#1253 |
OK to merge guys? @DanielFran or @mshima ? |
remove somes deprecated jdl options
#20656
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.documentation update