remove 'false' option for servicediscovery, websocket, messageBroker and searc… #20664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tcharl
force-pushed
the
jdl-improvement
branch
5 times, most recently
from
defd41f
to
4993028
Compare
Tcharl
force-pushed
the
jdl-improvement
branch
3 times, most recently
from
c156fef
to
61697fc
Compare
Tcharl
force-pushed
the
jdl-improvement
branch
from
61697fc
to
a911050
Compare
Tcharl
changed the title
|
Looks like it also fixes a bug on searchEngine :-) |
|
@DanielFran who to review this one? |
Tcharl
force-pushed
the
jdl-improvement
branch
from
dac9cf3
to
ac0d2d7
Compare
DanielFran
requested changes
Dec 26, 2022
Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
Tcharl
force-pushed
the
jdl-improvement
branch
from
2996c5a
to
b46ad79
Compare
Tcharl
force-pushed
the
jdl-improvement
branch
from
b46ad79
to
bc94e43
Compare
mshima
requested changes
Dec 26, 2022
Tcharl
force-pushed
the
jdl-improvement
branch
from
ace7e0d
to
f860423
Compare
Tcharl
force-pushed
the
jdl-improvement
branch
from
f860423
to
db2a449
Compare
6 tasks
DanielFran
requested changes
Dec 27, 2022
|
@Tcharl it will be needed to update documentation too, like in https://www.jhipster.tech/jdl/applications#options-in-applications |
Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
|
@DanielFran documentation PR is done: jhipster/jhipster.github.io#1253 |
|
OK to merge guys? @DanielFran or @mshima ? |
DanielFran
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove somes deprecated jdl options
#20656
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.documentation update