[Angular] Use let on metrics component #27108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonmert
force-pushed
the
simplifytemplate
branch
from
7b1efa4
to
0d29528
Compare
qmonmert
force-pushed
the
simplifytemplate
branch
from
0d29528
to
bbd4641
Compare
|
Drop metricsKeyExists? Looks irrelevant with optional chaining. |
|
@mshima I did a specific commit for that, is it what you wanted? |
mshima
reviewed
Aug 28, 2024
generators/angular/templates/src/main/webapp/app/admin/metrics/metrics.component.html.ejs
Outdated
Show resolved
Hide resolved
generators/angular/templates/src/main/webapp/app/admin/metrics/metrics.component.html.ejs
Outdated
Show resolved
Hide resolved
generators/angular/templates/src/main/webapp/app/admin/metrics/metrics.component.html.ejs
Show resolved
Hide resolved
generators/angular/templates/src/main/webapp/app/admin/metrics/metrics.component.html.ejs
Show resolved
Hide resolved
qmonmert
force-pushed
the
simplifytemplate
branch
from
04b17ea
to
eb9ade6
Compare
mshima
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.