-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : Added ng-bootstrap #4109
WIP : Added ng-bootstrap #4109
Conversation
7e2568c
to
2ce79c3
Compare
Sendil, lets do ng-bootstrap first. We can do a separate PR for bs4 else Thanks & regards, On 9 Sep 2016 13:36, "Sendil Kumar N" notifications@github.com wrote:
|
Okay then. Let me know if this is okay. If so will start migrating other components |
Also remove ui-bootstrap from client 2 so that we know exactly if something Thanks & regards, On 9 Sep 2016 13:48, d4udts@gmail.com wrote: Sendil, lets do ng-bootstrap first. We can do a separate PR for bs4 else Thanks & regards, On 9 Sep 2016 13:36, "Sendil Kumar N" notifications@github.com wrote: Wired and works. Navbar is working with ng-bootstrap elements There is a problem with adding NgbModules as a whole after this is fixed
You can view, comment on, or merge this pull request online at: #4109
File Changes
Patch Links:
— |
@@ -23,6 +27,8 @@ import { NavbarComponent } from './layouts/navbar/navbar.component'; | |||
HttpModule, | |||
<%=angular2AppName%>CommonModule, | |||
<%=angular2AppName%>AdminModule, | |||
NgbCollapseModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put these before our modules, after the HttpModule?
@sendilkumarn i have only one minor comment, once thats taken care of you can merge this. And start migrating other ui-bs stuff to ng-bs if you have time |
Wired ng-bootstrap
Tested Navbar with ng-bootstrap elements
There is a problem with adding
NgbModules
inapp.ng2modules.ts
as a whole after this is fixed angular-2, we can do that.