WIP : Added ng-bootstrap

[sendilkumarn]

Wired ng-bootstrap

Tested Navbar with ng-bootstrap elements

There is a problem with adding NgbModules in app.ng2modules.ts as a whole after this is fixed angular-2, we can do that.

[deepu105]

Sendil, lets do ng-bootstrap first. We can do a separate PR for bs4 else
it will too much to review and merge. Create another ticket for that and
tag it with ng2 label

Thanks & regards,
Deepu

On 9 Sep 2016 13:36, "Sendil Kumar N" notifications@github.com wrote:

Wired and works.

Navbar is working with ng-bootstrap elements

There is a problem with adding NgbModules as a whole after this is fixed
angular-2 angular/angular#11280

• Add bootstrap 4
• Replace ui-bootstrap with ng-bootstrap elements
• Revamp application to follow bootstrap 4 completely ( @deepu105
  https://github.com/deepu105 we can do revamp here )
• Remove ui-bootstrap dependancy
• Remove bootstrap 3 dependancy
• Polish and Publish

---

You can view, comment on, or merge this pull request online at:

#4109
Commit Summary

• feat(ng2): added gulp to move ng-bootstrap files

File Changes

• M generators/client-2/templates/gulp/_copy.js
  https://github.com/jhipster/generator-jhipster/pull/4109/files#diff-0
  (1)

Patch Links:

• https://github.com/jhipster/generator-jhipster/pull/4109.patch
• https://github.com/jhipster/generator-jhipster/pull/4109.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4109, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABDlF-s_hhX-1a45TQ0stqyqPN-cc2Lxks5qoRN7gaJpZM4J4zJH
.

[sendilkumarn]

Okay then.

Let me know if this is okay. If so will start migrating other components

[deepu105]

Also remove ui-bootstrap from client 2 so that we know exactly if something
else needs to be changed.

Thanks & regards,
Deepu

On 9 Sep 2016 13:48, d4udts@gmail.com wrote:

Sendil, lets do ng-bootstrap first. We can do a separate PR for bs4 else
it will too much to review and merge. Create another ticket for that and
tag it with ng2 label

Thanks & regards,
Deepu

On 9 Sep 2016 13:36, "Sendil Kumar N" notifications@github.com wrote:

Wired and works.

Navbar is working with ng-bootstrap elements

There is a problem with adding NgbModules as a whole after this is fixed
angular-2 angular/angular#11280

• Add bootstrap 4
• Replace ui-bootstrap with ng-bootstrap elements
• Revamp application to follow bootstrap 4 completely ( @deepu105
  https://github.com/deepu105 we can do revamp here )
• Remove ui-bootstrap dependancy
• Remove bootstrap 3 dependancy
• Polish and Publish

---

You can view, comment on, or merge this pull request online at:

#4109
Commit Summary

• feat(ng2): added gulp to move ng-bootstrap files

File Changes

• M generators/client-2/templates/gulp/_copy.js
  https://github.com/jhipster/generator-jhipster/pull/4109/files#diff-0
  (1)

Patch Links:

• https://github.com/jhipster/generator-jhipster/pull/4109.patch
• https://github.com/jhipster/generator-jhipster/pull/4109.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4109, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABDlF-s_hhX-1a45TQ0stqyqPN-cc2Lxks5qoRN7gaJpZM4J4zJH
.

[deepu105]

Can you put these before our modules, after the HttpModule?

[deepu105]

@sendilkumarn i have only one minor comment, once thats taken care of you can merge this. And start migrating other ui-bs stuff to ng-bs if you have time