bug/many2one_relationship_dropdown #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nicolas63
requested changes
Oct 19, 2022
| { | ||
| <%_ if (databaseType === 'mongodb') { _%> | ||
| var page = await Task.FromResult((_userManager.Users as IMongoQueryable<User>) | ||
| .Include(it => it.UserRoles) |
There was a problem hiding this comment.
user roles and role is not necessary
| .UsePageable(request.Page)); | ||
| <%_ } else { _%> | ||
| var page = await _userManager.Users | ||
| .Include(it => it.UserRoles) |
There was a problem hiding this comment.
user roles and role is not necessary
| { | ||
| <%_ if (databaseType === 'mongodb') { _%> | ||
| IPage<User> users = await (_userManager.Users as IMongoQueryable<User>) | ||
| .Include(it => it.UserRoles) |
There was a problem hiding this comment.
user roles and role is not necessary
| return users; | ||
| <%_ } else { _%> | ||
| return await _userManager.Users | ||
| .Include(it => it.UserRoles) |
There was a problem hiding this comment.
user roles and role is not necessary
| using Microsoft.AspNetCore.Identity; | ||
| using Microsoft.AspNetCore.Mvc; | ||
| using Microsoft.Extensions.Logging; | ||
| using Microsoft.EntityFrameworkCore; |
There was a problem hiding this comment.
there are multiple unused using
…ic user queries & user service
nicolas63
reviewed
Oct 19, 2022
|
|
||
|
|
||
| [HttpGet] | ||
| public async Task<ActionResult<IEnumerable<User>>> GetAllPublicUsers(IPageable pageable) |
nicolas63
requested changes
Oct 19, 2022
| private readonly IMediator _mediator; | ||
| <%_ } else { _%> | ||
| private readonly IMapper _mapper; | ||
| private readonly IMailService _mailService; |
There was a problem hiding this comment.
Can you remove unused fields (mailservice and user manager)
|
Kudos, SonarCloud Quality Gate passed!
|
nicolas63
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I created new controller ( PublicUsersControllers) who return only activated users.
This controller have route "/api/users".
Please make sure the below checklist is followed for Pull Requests.
All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed