-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Improvements #251
UI Improvements #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
label appears at two places in the home component. Could you remove the other one as well 😄
<span class="badge badge-danger">new</span> Check out <a routerLink="/statistics">JHipster statistics</a> to have an overview of what JHipster users are building. |
Ahh. I missed that one. It's done now. Thanks for letting me contribute. |
@ankitbeniwal : No worries. We greatly appreciate the contributions. 👍🏼 To make things consistent we need to do the same thing for the Continuous Integration page; notice that the select bar at the bottom has the same problem. Can we make it smaller and also left aligned with the text above it? Moreover, same problem applies for the Statistics page; could we make the select box smaller as before and also make the refresh button next to it? I am sorry I should have been more precise in my previous post. 😢 |
@SudharakaP I have modified the Statistics and the CI page as per the requirements. Kindly let me know if there is a need for any further changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SudharakaP I have fixed the statistics mobile view. Kindly check now. |
src/main/webapp/app/entities/statistics/statistics.component.html
Outdated
Show resolved
Hide resolved
src/main/webapp/app/entities/statistics/statistics.component.html
Outdated
Show resolved
Hide resolved
Remove the "new" label in statistics, make the select form tab have correct width and make the checkboxes more nicer. Resolves #237
@ankitbeniwal : Thanks much for your contribution. I've checked in the remaining small changes I've suggested to this branch and will merge this as soon as the CI passes. Please feel free to contribute more to jhipster in the future. Really appreciate your work. 😄 |
Hey @SudharakaP, Here are the changes as per our discussion in #237. Kindly check these out.
Resolves #237