Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements #251

Merged
merged 1 commit into from
Nov 11, 2020
Merged

UI Improvements #251

merged 1 commit into from
Nov 11, 2020

Conversation

ankitbeniwal
Copy link
Contributor

@ankitbeniwal ankitbeniwal commented Oct 19, 2020

Hey @SudharakaP, Here are the changes as per our discussion in #237. Kindly check these out.

Resolves #237

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@SudharakaP SudharakaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new label appears at two places in the home component. Could you remove the other one as well 😄

<span class="badge badge-danger">new</span> Check out <a routerLink="/statistics">JHipster statistics</a> to have an overview of what JHipster users are building.

image

@SudharakaP SudharakaP changed the title ✨ UI improvements UI Improvements Oct 19, 2020
@ankitbeniwal
Copy link
Contributor Author

Ahh. I missed that one. It's done now. Thanks for letting me contribute.

@SudharakaP
Copy link
Member

SudharakaP commented Oct 20, 2020

Ahh. I missed that one. It's done now. Thanks for letting me contribute.

@ankitbeniwal : No worries. We greatly appreciate the contributions. 👍🏼

To make things consistent we need to do the same thing for the Continuous Integration page; notice that the select bar at the bottom has the same problem. Can we make it smaller and also left aligned with the text above it?

image

Moreover, same problem applies for the Statistics page; could we make the select box smaller as before and also make the refresh button next to it?

image

I am sorry I should have been more precise in my previous post. 😢

@ankitbeniwal
Copy link
Contributor Author

@SudharakaP I have modified the Statistics and the CI page as per the requirements. Kindly let me know if there is a need for any further changes.

Copy link
Member

@SudharakaP SudharakaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the changes to the Statistics page break the responsiveness. What we now see is,

Screenshot

Screen Shot 2020-10-21 at 08 59 58

Whereas before it was,

Screenshot

Screen Shot 2020-10-21 at 09 02 15

In addition the the select box isn't left aligned with the text above even for larger screens.

Screenshot

image

@ankitbeniwal
Copy link
Contributor Author

@SudharakaP I have fixed the statistics mobile view. Kindly check now.

@SudharakaP SudharakaP changed the base branch from master to main November 2, 2020 03:15
Remove the "new" label in statistics, make the select form tab have correct width and make the checkboxes more nicer.

Resolves #237
@SudharakaP
Copy link
Member

@ankitbeniwal : Thanks much for your contribution. I've checked in the remaining small changes I've suggested to this branch and will merge this as soon as the CI passes. Please feel free to contribute more to jhipster in the future. Really appreciate your work. 😄

@SudharakaP SudharakaP merged commit a669a49 into jhipster:main Nov 11, 2020
@ankitbeniwal ankitbeniwal deleted the ui-improvements branch November 20, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JHOnline: improve UI
3 participants