fix statistics creation when creationTime is provided #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't been able to make the tests work on my local machine yet. Could you approve the workflow so that I can use the pipeline for testing? |
emilpaw
force-pushed
the
fix-yorc-statistics-creation
branch
from
760d296
to
091c2cd
Compare
emilpaw
changed the title
This fixes the bug where the request to save yorc statistics fails when a `creationTime` was provided in the `generator-jhipster` part of the entry payload. The issue is that `Instant.parse()` was called with a timestamp while it only accepts an ISO formatted instant. Fix jhipster/generator-jhipster#18238
emilpaw
force-pushed
the
fix-yorc-statistics-creation
branch
from
091c2cd
to
256c781
Compare
DanielFran
approved these changes
Apr 27, 2022
atomfrede
approved these changes
Apr 27, 2022
|
@DanielFran @pascalgrimaud Should we merge this? Will it be auto deployed to jhipster online (guess not)? |
|
the deploy is done only when there is a new tag |
|
I believe @pascalgrimaud needs to deploy a new version |
|
@DanielFran This can be merged, right? Then @pascalgrimaud could make a new tag to deploy it. |
|
@emilpaw Done. Thanks for contribution and do not forget to claim the bug bounty |
|
@pascalgrimaud Could you make a new tag? Since the statistics are not collected without this fix I think it's good to deploy it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where the request to save yorc statistics fails when
a
creationTimewas provided in thegenerator-jhipsterpart of theentry payload. The issue is that
Instant.parse()was called with atimestamp while it only accepts an ISO formatted instant.
Fix jhipster/generator-jhipster#18238