Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JHipster Statistics have had a significant drop #18238

Closed
mraible opened this issue Mar 29, 2022 · 12 comments · Fixed by jhipster/jhipster-online#357
Closed

JHipster Statistics have had a significant drop #18238

mraible opened this issue Mar 29, 2022 · 12 comments · Fixed by jhipster/jhipster-online#357
Labels
area: triage $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: undefined $300 https://www.jhipster.tech/bug-bounties/
Milestone
7.9.0

Comments

@mraible
Copy link
Contributor

mraible commented Mar 29, 2022

Overview of the issue

I just noticed that our statistics seems to have had a significant drop right after November 17, 2021.

https://start.jhipster.tech/statistics

Motivation for or Use Case

Statistics can be useful to see the choices our users are making.

Related issues

@pascalgrimaud theorized that it could be from the v7.4.0 release.

image
@mraible mraible added $100 https://www.jhipster.tech/bug-bounties/ $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ labels Mar 29, 2022
@emilpaw
Copy link
Contributor

emilpaw commented Apr 1, 2022

I am looking into this issue.

@mraible
Copy link
Contributor Author

mraible commented Apr 23, 2022

This is still happening, so I'm increasing the bounty.

@mraible mraible added $300 https://www.jhipster.tech/bug-bounties/ and removed $100 https://www.jhipster.tech/bug-bounties/ labels Apr 23, 2022
@atomfrede
Copy link
Member

atomfrede commented Apr 24, 2022 •
edited
Loading

Just had a quick look, it seems even with force-insight it looks like the statistics are not send (or does linking the generator for local development somehow overrule the force parameter and I didn't see the condition?)

@emilpaw
Copy link
Contributor

emilpaw commented Apr 24, 2022

@atomfrede How do you check if it's sent or not? It seems to send with my local setup.

@atomfrede
Copy link
Member

Works now or at least the method is called and axios has no error when posting the request.

@emilpaw
Copy link
Contributor

emilpaw commented Apr 24, 2022

I set up an HTTP interceptor and it shows that the generator in fact is sending out requests with correct looking statistics data. Later today I will take a look into the JHipster Online Server. Maybe it somehow does not accept the requests.

@atomfrede
Copy link
Member

Awesome. So I don't do that with the interceptor.

@emilpaw emilpaw mentioned this issue Apr 24, 2022
Merged
emilpaw added a commit to emilpaw/jhipster-online that referenced this issue Apr 25, 2022
@emilpaw
fix statistics creation when creationTime is provided
83c8ab9 
This fixes the bug where the request to save yorc statistics fails when
a `creationTime` was provided in the `generator-jhipster` part of the
entry payload. The issue is that `Instant.parse()` was called with a
timestamp while it only accepts a ISO formatted instant.

Fix jhipster/generator-jhipster#18238
emilpaw added a commit to emilpaw/jhipster-online that referenced this issue Apr 25, 2022
@emilpaw
fix statistics creation when creationTime is provided
46846ea 
This fixes the bug where the request to save yorc statistics fails when
a `creationTime` was provided in the `generator-jhipster` part of the
entry payload. The issue is that `Instant.parse()` was called with a
timestamp while it only accepts an ISO formatted instant.

Fix jhipster/generator-jhipster#18238
@emilpaw
Copy link
Contributor

emilpaw commented Apr 27, 2022 •
edited
Loading

The PR fixes the issue. Since it was a bug in JHipster Online and not the generator itself the statistics should also work again for already released versions of the generator.

@atomfrede
Copy link
Member

Nice work @emilpaw !

@DanielFran DanielFran added this to the 7.9.0 milestone Jun 22, 2022
@emilpaw
Copy link
Contributor

emilpaw commented Jul 18, 2022 •
edited
Loading

Hey, @DanielFran the fix was merged two months ago and there is no new release of JHipster Online yet.

What's the meaning behind adding it to the 7.9.0 milestone? I don't see a reason to wait for the next JHipster release.

@mraible
Copy link
Contributor Author

mraible commented Jul 26, 2022

I agree with @emilpaw. Can we release this soon?

@DanielFran
Copy link
Member

@mraible I am back too from holidays, will try to sync with @pascalgrimaud to release it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: triage $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: undefined $300 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
7.9.0
Development

Successfully merging a pull request may close this issue.

fix statistics creation when creationTime is provided emilpaw/jhipster-online
4 participants
@mraible @atomfrede @DanielFran @emilpaw