update 3rd party dependencies

[atomfrede]

Updating some dependencies. Should we remove the vendor.css.ejs as it is not used anymore, right?

We might have a problem with the dummy data or with instant/zoned date time fields in general. They seem to be a string instead of date. Will try to investigate a little further. The result is you can't edit entities with fake data for instant/zoned date time fields. Does someone know the current behavior?

• Please make sure the below checklist is followed for Pull Requests.

• Travis tests are green

• Tests are added where necessary

• Documentation is added/updated where necessary

• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

[atomfrede]

Maybe I was a bit to confident :( Will look into it. Looks like a problem with updated vue filters and changes in bootstrap vue. Manual tests are good though

[atomfrede]

So good news, there are some e2e tests failing (.btn-danger not found for example) so this might be problem with updated vue-bootstrap.

[sahbi-ktifa]

Sounds great, good job! Hope the CI will pass!

[atomfrede]

After I rebased the latest e2e improvements it looks much better and one test already passes. The remaining tests seem to be fixable, I guess due to some bootstrap changes the assertions are not correct anymore. Will investigate further

[vishal423]

@atomfrede, can you rebase against master to see if .modal related failed tests pass? I have updated po in recent changes

[atomfrede]

👍 Will do this evening.

[atomfrede]

I have found the problem. It relates to https://bootstrap-vue.js.org/docs/components/modal#lazy-loading-and-static-modals. Setting the modal property to static restores the old behavior, but I think lazy loading the content sounds like a good idea. Will try to adapt the e2e spec, but currently no idea how to do it to be honest.

[vishal423]

Can you try replacing expect(await deletePage.modal.isDisplayed()).to.be.false; by expect(await isVisible(deletePage.modal)).to.be.false; in delete user test case?

[atomfrede]

Will try. For the modal itself I have solution. Now the ok button is not found

[vishal423]

Can you also check the difference with entity delete tests that pass?

…

On Sun, Jul 14, 2019, 3:14 PM Frederik Hahne ***@***.***> wrote: Will try. For the modal itself I have solution. Now the ok button is not found — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#411?email_source=notifications&email_token=AD2BV4NNJXJ6CJNMO3YXNEDP7LYPFA5CNFSM4H4WEVM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4B3LA#issuecomment-511188396>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD2BV4KLPQBFG634OJP4FXLP7LYPFANCNFSM4H4WEVMQ> .