Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I've noticed that this library is not working on ruby 3.1 and doing some debug I've found the following:
Ruby 3.1 uses psych 4.0.3 by default and this version doesn't support the deprecated way we call
YAML.safe_load
.Before:
After:
This new psych version also allows us to use some of the its defaults when calling
safe_load
.Method definition: https://github.com/ruby/psych/blob/e8d262fa108a1605443d7426c185452b538775be/lib/psych.rb#L323
Ruby 2.6.0 and up uses psych 3.1.0 which introduces this new method signature.
If we want to support old psych versions we will need create a conditional based on the gem version like it's done in this blog post.
Please let me know if changes are needed.
Thank you for your time and effort maintaining this library! 🙇 💐