This repository has been archived by the owner on May 20, 2022. It is now read-only.
simplify subscription system, adds examples #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ejkkan as the original author of the feature, could you tell me how you feel about the change? |
davidcostadev
approved these changes
Aug 30, 2019
|
It think this brings a more versatile usage of the subscriber! Good job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current subscription system is great, but it does not fit with the theme of the library, IMO. After some personal usage and getting opinions from other devs and even a professional team that is using the lib, we came into the agreement that the library should keep providing
foundationalfunctionality that enables many use cases and implementations, so keeping it simple is the goal.This refactors allows the current system (action based subscriptions) to be implemented externally if the developer wants it, since it keeps calling callbacks with the
actionobject.So the library core keeps small and simple, while it can easily be incremented using wrappers, as long as it keeps providing the same information to the subscribers.