Extracting POD synopsis from FatPacked modules #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhthorsen
requested changes
Nov 21, 2017
There was a problem hiding this comment.
I like the change, but I would very much like an unit test. Don't think it should be too hard to extend https://github.com/jhthorsen/applify/blob/master/t/help.t ..?
lib/Applify.pm
Outdated
| @@ -350,6 +350,16 @@ sub _print_synopsis { | |||
| unless (-e $documentation) { | |||
| eval "use $documentation; 1" or die "Could not load $documentation: $@"; | |||
| $documentation =~ s!::!/!g; | |||
| # might be FatPacked $INC{"$documentation.pm"}{"$documentation.pm"} | |||
| if (ref($INC{"$documentation.pm"})) { | |||
There was a problem hiding this comment.
How about if (ref $INC{"$documentation.pm"} eq 'HASH') ?
There was a problem hiding this comment.
I know a lot more about require now. The %INC entry is a FatPacked object that must have an INC method which returns a readable filehandle.
jhthorsen
approved these changes
Nov 24, 2017
|
Merge when you feel like it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm considering fatpacking some applify scripts and have found that when using something akin to the included code. The
_print_helpdoesn't when the script is fatpacked for thescript list -helpas$INC{'App/Command/List.pm'}is aFatPacked::HASHthat cannot be opened.script -helpis functional fatpacked, as isscript list -helpin un-fatpacked form.This appears to fix it but needs improvement and tests for which I'm at a loss on how to construct.