Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS Support #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add TLS Support #80

wants to merge 1 commit into from

Conversation

hazemkmammu
Copy link

  • Add TLS Support by accepting TLS options and passing them to Mojo::IOLoop::Client.

@hazemkmammu
Copy link
Author

hazemkmammu commented Oct 9, 2023 •
edited
Loading

@jhthorsen Hi Jan. Could you please review this change? This should add support for TLS connection to Redis. SSL/TLS is supported by Redis starting with version 6. Please let me know if you have any questions. Thanks.
cc: @Grinnz

Add TLS Support
a356a19 
- Add TLS Support by accepting TLS options and passing them to Mojo::IOLoop::Client.
jhthorsen
jhthorsen requested changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, but I think there's too many attributes. Also, the documentation should get some updates.

.gitignore
@@ -13,3 +13,4 @@
/META*
/MYMETA*
/pm_to_blib
.idea/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

lib/Mojo/Redis.pm
has 'tls_ca';
has 'tls_cert';
has 'tls_key';
has 'tls_options';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have this part of the "url", like https://docs.mojolicious.org/Mojo/Server/Daemon#listen

Example:

Mojo::URL->new("redis://localhost?ca=ca.pem&cert=cert.pemt&key=key.pm")

And "tls" can be set to true if key and cert exists.

@jhthorsen jhthorsen added the enhancement New feature or request label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhthorsen jhthorsen jhthorsen requested changes

Assignees

@hazemkmammu hazemkmammu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hazemkmammu @jhthorsen